Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtool_1_5: remove used-in-fetchurl warning #180672

Merged
merged 1 commit into from Jul 8, 2022
Merged

libtool_1_5: remove used-in-fetchurl warning #180672

merged 1 commit into from Jul 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2022

Description of changes

This commit removes the "Note: this package is used for bootstrapping fetchurl..." warning from the old libtool 1.x, which is not actually "used for bootstrapping fetchurl".

As far as I can tell it isn't used for anything in-tree other than one maintainerless package of canon binary printer drivers.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 8, 2022
@ghost ghost mentioned this pull request Jul 8, 2022
13 tasks
@SuperSandro2000 SuperSandro2000 merged commit 49d87bd into NixOS:master Jul 8, 2022
@ghost ghost deleted the pr/libtool15/not-used-by-fetchurl branch January 23, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants